Ask HN: How to deal with long vibe-coded PRs?

2 pointsposted 18 hours ago
by philippta

Item id: 45744209

8 Comments

zigcBenx

18 hours ago

In my opinion no PR should have so much changes. It's impossible to review such things.

The only exception is some large migration or version upgrade that required lots of files to change.

As far it goes for Vibe coded gigantic PRs It's a straight reject from me.

JohnFen

13 hours ago

I'd just reject it for being ridiculous. It didn't pass the first step of the review process: the sniff test.

brudgers

11 hours ago

Charitably, even though it is not what you or I would do, the pull request could be a best good faith effort of a real human being.

So to me, it's less about being ridiculous (and "ridiculous" is a fighting word) and more a simple "that's not how this team does things because we don't have the resources to work that way."

Mildly hurt feelings in the most likely worst case (no food for a viral overtop tweet). At best recruitment of someone with cultural fit.

JohnFen

10 hours ago

My objection to a PR like this has nothing to do with whether or not a human wrote it. It's that the PR is too large and complex. The reason I'd give for rejecting it would be that. I wouldn't say "it's ridiculous" as the reason. I would 100% be thinking that, though.

brudgers

9 hours ago

That’s good.

My experience is “too large/complex” provides an opening for arguementivenes and/or drama.

“We don’t do it like this” does not so much. It is social, sufficient and not a matter of opinion (“too” is a matter of opinion).

wengo314

18 hours ago

reject outright. ask to split it into reasonable chain of changesets.