MiroslavPokorny
a day ago
The folder structured shared is broken for the simple fact that artifacts are categorised by programming type rather than usage. As an example all models are grouped together broken away from the services that may be using them. This means the relationship between a collaborating system are never colocated.
I fail to see the value of grouping all models together, maybe its me but i would rather that collaborators are co-located. I cant see any value to have all models.
notpushkin
a day ago
Agreed. I’m trying to group files roughly by “feature”:
src/features/
auth/
models.xx
api.xx
components/SignInModal.xx
todos/
models.xx
acls.xx
api.xx
pages/Todo{List,Create,Edit}Page.xx
MiroslavPokorny
a day ago
Maybe its me, but wouldnt the auth feature only have 1 or 2 models at most ? Same question for API and components, pretty sure you could put them in the parent directory and the names of each shoudl make their core responsibility obvious.
notpushkin
21 hours ago
> wouldnt the auth feature only have 1 or 2 models at most
Probably! (Sessions, OIDC connections, probably users if small enough.)
I don’t think putting it all together into the root directory is the way to go. The idea is to store everything related to one particular feature together, so that all the relevant code stays in one place:
// features/auth/models.ts
class User { ... }
// features/auth/api.remote.ts
import { User } from "./models";
export const authorizeUserForm = form((username, password) => { // [1]
// ...
});
// features/auth/components/SignInDialog.tsx
import { authorizeUser } from "../api.remote";
export default () => <form {...authorizeUserForm}>
...
</form>;