Bun has an open PR adding shared-memory threads to JavaScriptCore

58 pointsposted 3 hours ago
by gr4vityWall

59 Comments

pizlonator

2 hours ago

CharlesW

an hour ago

That's excellent work and a great read, Filip!

quotemstr

21 minutes ago

Yes, you did. And it's a good design. You even did the GC question justice.

My concern is more in the spirit of "Your scientists were so preoccupied with whether or not they could, they didn't stop to think if they should.". Of course JS being single threaded wasn't a hard constraint. Lift it, and people like you can use the parallelism to do great things.

The problem is that most developers are not you. Shared memory concurrency is foot-artillery (especially if truly parallel). Adding threads to the JS ecosystem is selling W48 nuclear artillery shells at the toy store.

JS's ostensible limitation to a single thread forced users to do what they should have been doing anyway: message-passing, thread-per-core architecture, and actor-ish stuff. People who don't know better reach for shared memory concurrency because it seems like a good way to solve problems, but it's actually a dangerous attractor in idea space. JS engine limitations were accidentally keeping people away from it. Now that they can hear the siren's song of a mutex, they'll run around on the hard problems of parallel programming.

Now, that's not a reason to avoid shipping such a system. It's just not something I would have chosen to implement for the masses.

nasretdinov

an hour ago

The code needs to be not in the state of "no obvious bugs", but "obviously no bugs". Especially the programming language runtime. Otherwise there is no hope you can sustain any development whatsoever

pizlonator

an hour ago

No language runtime is ever in a state of "obviously no bugs".

Good luck demanding that of anything of JSC's or LLVM's complexity

norir

13 minutes ago

Perhaps then it would be better to not use tools of this level of complexity.

nasretdinov

a few seconds ago

I think LLVM is a perfect example of what happens when it's too complicated: it's slow, it's bug-ridden when you stray away from the beaten path (e.g. Rust hits bugs in LLVM like this one https://www.reddit.com/r/rust/comments/l4roqk/a_fix_for_the_... ), and it's really hard to use and understand.

It's obviously not useless because of that, but it's a great example of what happens when you cannot fully control the implementation complexity

spankalee

3 minutes ago

So don't use compilers at all?

peesem

3 minutes ago

how would you suggest we compile literally anything?

TomatoCo

an hour ago

On one hand, sure, the entire point of a programming language is to make complex ideas able to be expressed in simpler abstractions. On the other hand, we can damn well try.

pizlonator

an hour ago

Damn well trying to enforce an "obviously no bugs" rule in a language runtime would mean zero progress in language runtimes.

We certainly wouldn't have gotten to where we are with runtime and compiler quality and performance if we had damn well tried to enforce such a rule

nasretdinov

36 minutes ago

IMO the very minimum requirement should be that you've demonstrated effort to reduce unnecessary complexity of the problem. Sure, some problems are complex enough that there might not exist an obvious solution, yet usually after a while once you're familiar with some topic the existing solutions do start to appear obvious. If they're not I'd argue we're doing something very very wrong

pizlonator

31 minutes ago

Adding concurrency to JavaScript definitely falls in the "complex enough" category

So does basically any feature or optimization in a JS runtime

nasretdinov

19 minutes ago

I think it's also worth distinguishing _problem complexity_ and _solution complexity_. The problem might be really really hard (and it very obviously is in the case of adding multi-threading to JavaScript). But it does not mean that the solution has to be hard to understand. It doesn't mean that any average PHP developer (I can say that, I started with PHP) should be able to verify the correctness of the patch, but for a person who is well familiar with the area there shouldn't exist areas they can't understand.

Look at the description of your own Fil-C: it focuses on clarity of explanation of how it works, and it actually does make sense (and, hopefully, works well enough too). Compare that with the pull request sent here. I'll wait

pizlonator

a minute ago

The solution to concurrency in JS is hard to understand and I would expect even hardened JSVM folks (me included) to be super confused by it

sothatsit

6 minutes ago

It’s pretty incredible to me that a mammoth change like this is possible to prototype now using LLMs.

It makes me wonder how much of our software stack will become more malleable to big ideas annd experiments again, like Filip’s idea here. If capabilities of agents continue to improve, and costs continue to fall, big audacious changes like this could become much more feasible. I’m actually quite hopeful this could lead to big improvements in our software, even if maintenance burdens and testing still concern me quite a bit.

Retr0id

2 hours ago

Is there a human-authored description of the PR anywhere?

How are there not race conditions all over the place?

pizlonator

an hour ago

It's substantially based on my design, read the blog post I wrote (linked in another comment here)

It's a very complex thing, but not impossible. I'm very impressed that any LLM can do this

asxndu

an hour ago

I am shocked by how good and comprehensive the bun docs & ecosystem is.

Its so well contained I never need to look outside its ecosystem for basic components. It's a true "Batteries Included" runtime.

Retr0id

an hour ago

Last time I read the bun docs I spotted an off-by-one bug in sample code, so I opened a github issue. An AI bot responded, confirming the issue, and opened a PR to fix it - A simple "+ 1" added in the right place. Two other AI bots reviewed the PR, which went on for several rounds of "improvements". Last time I checked, neither the issue nor the PR received any human attention (actually I just checked again, and the PR has been closed by stalebot).

asxndu

41 minutes ago

Was the bug actualy soved?

fg137

33 minutes ago

Yet I rarely hear about it being used in production systems and replacing Node.js.

torben-friis

25 minutes ago

>Scalability, measured (the honest section)

Ugh.

richardbarosky

37 minutes ago

Don't have much to say on the topic but recalled this excerpt from the book Coders at Work in the chapter interviewing Douglas Crockford.

``` In my experience, the worst bugs are the real-time bugs, which have to do with interactions with multiple threads. My approach to those bugs is to avoid making them. So I don't like threads. I think threads are an atrocious programming model. They're an occasionally necessarily evil, but they're not necessary for most of the things we use threads for.

One of the things I like about the browser model is that we only get one thread. Some people complain about that—if you lock up that thread, then the browser's locked up. So you just don't do that. There are constantly calls for putting threads into JavaScript and so far we've resisted that. I'm really glad we have.

The event-based model, which is what we're using in the browser, works really well. The only place where it breaks down is if you have some process that takes too long. I really like the approach that Google has taken in Gears to solving that, where they have a separate process which is completely isolated that you can send a program to and it'll run there. When it's finished, it'll tell you the result and the result comes back as an event. That's a brilliant model. ```

RealityVoid

26 minutes ago

Soo... Essentially, still threads, but no shared state between threads, and they talk through this message interface?

piterrro

24 minutes ago

think of all the poor web devs trying to use multiple threads on top of asynchronous operations. wild.

gavinray

an hour ago

One of the biggest things preventing software like SQL DB's from being written in TypeScript is the lack of proper threading.

I genuinely think you could write a competitively-performant multi-threaded DB in Bun + TS if you had shared-heap threads and fast atomics/locking primitives.

n_e

36 minutes ago

You have service workers, and for shared memory and synchronisation respectively SharedArrayBuffer and the Atomics namespace.

quotemstr

4 minutes ago

Exactly. Nothing stops your writing a high-performance parallel database in TypeScript today. Given that runtimes and tooling are actually pretty good, I think TypeScript is actually a fine choice of language for the task.

The only thing you can't do with JS today is share a heap across threads. You have SharedArrayBuffer. You have atomics. You don't need a shared address space.

There's a high performance database called "PostgreSQL" you may have heard about. It doesn't use threads. It uses separate processes and shared memory: just like standard JavaScript, with its service workers and SharedArrayBuffer.

If not sharing an address space is good enough for PostgreSQL, it's good enough for your TypeScript database.

The problem with shared-everything, unmarked, preemptive-parallel concurrency is that 90% of the time it gets used by people who don't know they shouldn't.

Groxx

33 minutes ago

Are you hoping to, like, run postgres in nodejs or something?

You can get parallelism with web workers and shove sqlite over there if you like, e.g. for running more intensive queries. Beyond that I kinda don't see much of a reason to use JS for databases, except maybe for isolation (e.g. via wasm).

piterrro

an hour ago

I honestly should print that comment and hang it on a wall.

> …competitively-performant… Care to explain competitively to what?

forrestthewoods

an hour ago

…but why? JS/TS does not seem like the right tool for the job?

nesarkvechnep

an hour ago

It's probably what they know so not anything new should be learned.

anematode

an hour ago

This is terrifying. Evidently based on prior art by Mr. Pizlo – indeed, where's the acknowledgement of that?? (edit: I missed it) – but I'm assuming that was never translated into code.

I love the idea of experimentation and innovation; I abhor the idea of it being dependent on Anthropic and their theft. I've never rooted for the Chinese labs more strongly than after seeing this.

bojan

an hour ago

The acknowledgement is in the PR description, section "The design, and what it's based on".

Yoric

an hour ago

Eh, Firefox/Thunderbird had multi-threaded JS in SpiderMonkey in the late 90s.

Then it was removed it because it made garbage-collection a real mess (the JavaScript gc needs to walk through lots of C++ data, some of it may have specific requirements for destruction/finalization).

I hope it's better this time :)

pjmlp

an hour ago

The JS / interoperability is why V8 eventually added a C++ GC.

applfanboysbgon

an hour ago

Imagine somebody doing a drive-by on your repo and dropping a 270k loc PR expecting you to merge it. Bonus points if they can't even put in the 0.001% smidgen of effort to write why they think the PR is useful or necessary in their own words. Oh, but we don't have to imagine it, because there are people who actually do that!

Retr0id

an hour ago

The PR is against bun's fork of WebKit, not upstream.

fg137

32 minutes ago

The title is of this post is definitely confusing if not misleading.

applfanboysbgon

an hour ago

Oh, my mistake, I thought they were doing the zig thing again.

quotemstr

40 minutes ago

I know a thing or two about VMs. Reading this post, I thought to myself "No way it was this easy. No performance hit in the single threaded case? No way".

I was right. Buried in the middle of the post is this tidbit:

> v1 collects synchronous and stop-the-world

Ah, there it is! I knew it!

Parallel garbage collection is a very hard problem. Years of experience and subtle implementation are required to get something like ZGC. A stop-the-world garbage collector will kill tail latency in many use-cases, especially for large programs. I'd say a good GC is the hardest part of a modern VM, even harder than a good JIT: not that a JIT is easy.

Show me multi-threaded JS with generational mark, sweep, compaction, etc. running in parallel with the mutator and I'll be impressed. (The smart thing would be to base it on the JVM or CLR. Doesn't count though.)

It's all so exhausting, this current programmer culture of doing the easy part of a system thing X and presenting your work, without qualifiers, as a complete and modern X.

Sure, sure, we can have memory safe C (just don't have any data races!). Sure, we can have an AI C compiler (just don't expect type checking). Sure, we can port SQLite to Rust (but don't expect it to be fast). Sure, you can one shot a Slack clone (just don't expect performance or security). Doing the easy part of a thing is not doing the thing! You can't trust a README's feature list these days.

To be fair, given that the README is obviously unedited LLM output, the authors might not have realized that their agents cheated and made threading easy by pessimizing the GC. The LLM certainly did though.

Now, maybe the JSC really is adaptable to a multi-threaded mutator world. If it is, great. But over and over, I've seen AI say "I will defer and charter $HARD_THING" and mean "I have no idea how to do $HARD_THING, so I'm creatively reinterpreting your request to make it easy". You have to be endlessly vigilant for LLMs subtly twisting your tasks into easy versions that might technically meet the requirements but they are less complete than you intend.

adem

an hour ago

I will never get over the overuse of adjectives like "real" in LLM outputs, it dilutes the meaning of these words.

Nnnes

34 minutes ago

Related, spinning "I did something poorly" into "I am being honest"

> Scalability, measured (the honest section)

so what about the other sections?!

lgtx

an hour ago

Counting 62 em-dashes in the PR description alone, are people reading those walls of slop anymore?

bakugo

41 minutes ago

No human has ever read or will ever read the PR description.

No human has read or will ever read any of the code, nor was any human thought involved in its creation.

Everything is performative now. As long as you just keep your eyes closed and believe it all works, that's all that matters.

slopinthebag

an hour ago

Course not. They have an LLM summarize it for them.

MuffinFlavored

an hour ago

I know a ton of people absolutely hate this level of "LLM code + LLM PR description + LLM PR review" but my boss would have an orgasm if I was able to use AI half as well in our org... :/

Atotalnoob

an hour ago

Just stop caring about quality. It makes it 10x easier to produce slop with AI if you never bother to check

Yoric

44 minutes ago

I just wrote an internal report in my company.

My conclusion from the project I'm working on is that, as of this day, there is no way to have both this so-called 20x performance improvement _and_ any kind of quality. Or security if whoever is running the agent has any token in an .env anywhere on the same file system.

We'll see in which direction the CTO takes this. My bet is not on quality.

rustystump

an hour ago

It is sad. This is a new reality. No one reads code, it is agents all the way down. It has been long enough now that I can safely say AI has not sped up project delivery nor improved quality when it did ship.

Is it the AI or the people using it? Idk

stephen

an hour ago

Amazing. This is what the Typescript team should have done instead of rewriting to golang -- innovate the runtime.

bastawhiz

an hour ago

That doesn't help anyone using Node. I don't want to have to start using a new runtime because my compiler is slow. That's wild.

stephen

an hour ago

You're already using a new runtime with tsgo -- it's golang at build time -- but still running Node in prod, so the same could work here. :-)

Agreed I would not want all Typescript users forced to use /this/ runtime, but if the TS team shipped tsc as "oh now it's uses a special fast JS runtime" (just like tsgo is a different runtime) I'd love to at least have the option of using the same special fast runtime in my own still-written-in-TS apps.

Seems I've either struck or a nerve, or miscommunicated, given the insta down votes.