esperent
a day ago
> If you are a user of github.com, consider how it has changed since 2020.
I've been a GitHub user since around 2016. My overall impression is that it's gotten slightly better over the last couple of years but not really changed that much.
eloisius
a day ago
In my opinion it’s gotten worse in favor of cost savings. Two biggest examples: if you leave more than 10 code review comments on a PR, it hides them under a “show more” link. Time and time again my reviews get ignored, so I’ve started subconsciously picking my battles when doing a one. That might be good on small PRs so that you don’t go into the weeds nit-picking, but on a big gnarly one it’s an anti-feature. And in any case, I don’t want Microsoft’s cheap UI to inform the code review etiquette of my team. Second example: if a file in a PR has a large diff, it will not be loaded, you have another “show more” link. That file is probably the part of your PR most in need of review, but again, on my PRs my teammates often skip right past it because it’s hidden by default.
esperent
a day ago
That's a fair complaints. However, it's clearly a design decision, whereas the author is trying to imply that it's gotten generally worse because they switched to using a frontend framework.
eloisius
a day ago
I agree with her. I appreciate the new code navigation stuff a bit, but not at the cost it’s imposed on my workflow. A pull request used to be a regular web page. I could refresh it, search it with ctrl-f, reliably link to a specific line, etc. Now it’s a crapshoot. If you refresh there’s no guarantee you’ll land anywhere near where you were. Page loads take forever so I can’t easily open multiple tabs to cross-reference the code I’m reviewing. If you link to some code that was within a diff that you had to “show more” to open, well, who knows where the link will land you.
user
a day ago
johnnypangs
a day ago
Doesn’t github use Rails and web components? They definitely gotten more frontend heavy though…
https://github.blog/engineering/architecture-optimization/ho...
yen223
a day ago
The Github frontend appears to be React now.
That said, most (not all) of it still works with Javascript disabled
johnnypangs
19 hours ago
I looked a bit into the JavaScript loaded when going to GitHub and my best guess as to what it’s using react for is the copilot chat.
It’s still using turbo rails and doing full ssr reloads. Something very at odds with react router which it’s also loading.
It’s still loading catalyst (their homebrew web component lib) which from what I understand doesn’t seem to offer react bindings. It even loads lit (another web component lib), which I couldn’t find the react bindings for.
If it’s just for the copilot chat I’d still say GitHub is mainly rails based though would love to hear if anyone has any more / better insight.
bryanrasmussen
a day ago
some frontend frameworks - the React like ones - make that kind of design decision so easy to do that you might just do it without arguing if it was a good decision or not.
Not that it is particularly difficult with Vanilla JS etc. but maybe slow enough you think, hey why are we doing this?
React it's 5 seconds to do, you are done so quick with the actual code you might not consider the implications.
KPGv2
a day ago
Indeed, being able to click on a variable in code and get a panel on the right that lists every occurrence of the variable including the definition is such an improvement over how it used to be. That feature alone makes GH2024 superior.
I don't want to have to clone a repo every time I want to browse code with a better experience than Notepad.
mdhb
a day ago
It’s completely unusable on iOS. Back and forward functionality only work intermittently among a bunch of other problems.
Klonoar
a day ago
I’ve noticed the same with YouTube.
Yes, these are obviously separate properties - I’m moreso noting that it’s absurd that multiple large separate properties with well compensated engineering teams have shipped messed up basic back/forwards functionality in 2024.
I typically try to find the most charitable take on something but this kind of thing is consistently blowing my mind.
eclipxe
21 hours ago
I just tried YouTube And back and forward works just fine. Exactly how I would expect. Can you expand more on what you see?